Update calculation of time-averaged radiation variables #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbk2004
added a commit
that referenced
this pull request
Nov 12, 2024
… CAPE cases + #2459 (#2461) * UFSWM - Add tests-dev ATM-only idealized dry baroclinic wave test and a 2020 July CAPE case * UFSWM - Update modulefile to support Rocky 8 on CSPs, with ParallelWorks --------- Co-authored-by: Wei Huang <[email protected]> Co-authored-by: Jong Kim <[email protected]>
tsga
added a commit
to tsga/ufs-weather-model
that referenced
this pull request
Nov 13, 2024
* develop: Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + ufs-community#2459 (ufs-community#2461) Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458) Fix/cpld sfs rt + Pull in units updates from FV3 ufs-community#2467 (ufs-community#2475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This PR fixes incorrect diagnostic output for fhzero-averaged radiation output variables. Presently, there is a significant "sawtooth" appearance to these fields (such as dswrf_ave and ulwrf_avetoa) when we expect smoother lines with jumps only at fhzero diagnostic reset times. Here is an example of the present (OLD) result and the result from the current PR (FIX) from a 24-hour S2S regression test forecast.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: